[webkit-reviews] review granted: [Bug 71261] PluginProxy shouldn't use window-relative coordinates : [Attachment 113118] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 71261: PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261

Attachment 113118: Patch
https://bugs.webkit.org/attachment.cgi?id=113118&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113118&action=review


> Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:151
> -    IntRect dirtyRectInPluginCoordinates = dirtyRect;
> -    dirtyRectInPluginCoordinates.move(-m_frameRectInWindowCoordinates.x(),
-m_frameRectInWindowCoordinates.y());
> -
> -    m_backingStore->paint(*graphicsContext, contentsScaleFactor(),
dirtyRect.location(), dirtyRectInPluginCoordinates);
> +    m_backingStore->paint(*graphicsContext, contentsScaleFactor(),
dirtyRect.location(), dirtyRect);

If I were just to read this code change on its own, I would think that you are
now passing a dirtyRect in window coordinates to paint(), since you are no
longer converting to plugin coordinates. Perhaps the ChangeLog should explain
that dirtyRect is now already in plugin coordinates so no conversion is
necessary.