[webkit-reviews] review denied: [Bug 71239] update results for /media/track/track-mutable-expected.txt and /media/track/track-text-track-cue-list-expected.txt : [Attachment 113173] updating to ToT

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has denied Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 71239: update results for /media/track/track-mutable-expected.txt and
/media/track/track-text-track-cue-list-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=71239

Attachment 113173: updating to ToT
https://bugs.webkit.org/attachment.cgi?id=113173&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113173&action=review


> LayoutTests/media/track/track-mutable-expected.txt:6
> +TypeError: Cannot read property 'length' of undefined

We don't usually like to check in expectations that aren't correct. Usually we
check in the correct expectations, mark the test as failing, and work up to
matching the correct expectations. The exception is that sometimes we'll check
in incorrect expectations for a specific platform, but this patch is modifying
the platform independent version.

Maybe you can provide some more background about what you are trying to
achieve.

> LayoutTests/platform/chromium/test_expectations.txt:-82
> -BUGWK43668 SKIP : media/track/track-mutable.html = TIMEOUT

For example, instead completely removing the SKIP, it is more typical to allow
it to run but expect that there is a text difference in the results:
BUGWK43668 : media/track/track-mutable.html = TEXT