[webkit-reviews] review granted: [Bug 61707] Race condition in full screen controller, which leads to problem when web process crashes : [Attachment 95308] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 61707: Race condition in full screen controller, which leads to problem
when web process crashes
https://bugs.webkit.org/show_bug.cgi?id=61707

Attachment 95308: Patch
https://bugs.webkit.org/attachment.cgi?id=95308&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:410
> +    if (!_isExitingAcceleratedCompositingMode)
> +	   return;

This shouldn’t happen. It’s good to be prepared for this, but I suggest
asserting that it doesn’t happen, in addition.

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424
>> +	[self release]; // Balanced by retain in exitAcceleratedCompositingMode
below.
> 
> I have corrected this to say “above” locally.

Please also correct the name of the method the comment is referring to!