[webkit-reviews] review granted: [Bug 61712] Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page : [Attachment 95307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 29 17:08:48 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 61712: Embedded Vimeo video, when taken fullscreen, is overlapped by
content from the enclosing page
https://bugs.webkit.org/show_bug.cgi?id=61712

Attachment 95307: Patch
https://bugs.webkit.org/attachment.cgi?id=95307&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I'm not really a fan of how we touch style in ancestor documents, and I suspect
that there's a way to re-parent whole iframes that will escape your bit
maintenance. But this seems like an OK approach in the short term. Please test
thoroughly.

Please file a new bug to explore alternative ways to fix this, e.g. by doing
stuff in RenderLayer.

Oh, and a testcase would be good.


More information about the webkit-reviews mailing list