[webkit-reviews] review denied: [Bug 54826] [GTK] Add a setting to change the pixels per line used for scrolling : [Attachment 92395] Setting to change the pixels per line added.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 10:37:57 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Peter Hatina
<phatina at redhat.com>'s request for review:
Bug 54826: [GTK] Add a setting to change the pixels per line used for scrolling
https://bugs.webkit.org/show_bug.cgi?id=54826

Attachment 92395: Setting to change the pixels per line added.
https://bugs.webkit.org/attachment.cgi?id=92395&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92395&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:75
> -    // FIXME: retrieve the user setting for the number of lines to scroll on
each wheel event
> -    m_deltaX *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> -    m_deltaY *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> +    Settings* settings = Settings::globalSettings();
> +    m_deltaX *= settings->scrollPixelCount();
> +    m_deltaY *= settings->scrollPixelCount();

I think this comment actually refers to retrieving the setting from GTK+.  I do
not think it is worth exposing this kind of low-level option through the API.
If there is a default GTK+ value for this though, we should be sure to use it
so that scrollbars move in a more native way.

Personally I do not find anything wrong with the current scrollbar behavior and
feel we can probably just remove the comments and close the bug. I could be
wrong though and perhaps our scrollbars could move more natively during wheel
events.


More information about the webkit-reviews mailing list