[webkit-reviews] review granted: [Bug 61260] [Chromium]Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window. : [Attachment 94730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 10:28:13 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 61260: [Chromium]Call setToolTipText() in WebPopupMenuImpl mouse move
handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260

Attachment 94730: Patch
https://bugs.webkit.org/attachment.cgi?id=94730&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94730&action=review

> Source/WebKit/chromium/public/WebWidgetClient.h:86
> +    virtual void setToolTipText(const WebString&, WebTextDirection hint) { }


be sure to cleanup the chromium side so that the methods are declared in the
proper order in render_view.{h,cc}.


More information about the webkit-reviews mailing list