[webkit-reviews] review granted: [Bug 19995] hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments. : [Attachment 95035] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 19995: hixie.ch : anchor Link fails with fragment identifiers inside SVG
fragments.
https://bugs.webkit.org/show_bug.cgi?id=19995

Attachment 95035: Patch
https://bugs.webkit.org/attachment.cgi?id=95035&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95035&action=review

Good catch, r=me.

> LayoutTests/svg/hixie/links/003.xml:17
> +  window.layoutTestController.waitUntilDone();
> +  window.layoutTestController.dumpAsText();

You can omit window. here, it's in the default lookup chain, not in the if()
line though.

> LayoutTests/svg/hixie/links/003.xml:25
> +    window.layoutTestController.notifyDone();

Ditto.