[webkit-reviews] review granted: [Bug 61578] HTMLVideoElement::currentSrc() should return a KURL : [Attachment 95132] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 07:00:11 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 61578: HTMLVideoElement::currentSrc() should return a KURL
https://bugs.webkit.org/show_bug.cgi?id=61578

Attachment 95132: Patch
https://bugs.webkit.org/attachment.cgi?id=95132&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95132&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:678
> +    LOG(Media, "HTMLMediaElement::loadResource(%s, %s)",
urlForLogging(initialURL).utf8().data(), contentType.raw().utf8().data());

Ha.  Seems urlForLogging should return a char*...

>> Source/WebCore/rendering/HitTestResult.cpp:315
>> +	    return mediaElt->currentSrc();
> 
> I believe this is the same code because currentSrc has already his baseURL
set.

Is this tested anywhere?  How do I as a reviewer know it's already absolute. :)


More information about the webkit-reviews mailing list