[webkit-reviews] review granted: [Bug 61516] LevelDB: turn on paranoid checks and verify checksums, log errors : [Attachment 95143] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 61516: LevelDB: turn on paranoid checks and verify checksums, log errors
https://bugs.webkit.org/show_bug.cgi?id=61516

Attachment 95143: Patch
https://bugs.webkit.org/attachment.cgi?id=95143&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95143&action=review

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:257
> +    readOptions.verify_checksums = true;

To David's point, perhaps just add a FIXME here mentioning that removing this
might be a perf win once the API is more stable.