[webkit-reviews] review granted: [Bug 61517] IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end : [Attachment 94958] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 61517: IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=61517

Attachment 94958: Patch
https://bugs.webkit.org/attachment.cgi?id=94958&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94958&action=review

> Source/WebCore/ChangeLog:5
> +	   IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end

If possible, a link to this part of the spec in the ChangeLog would be nice.

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:839
> +    CursorImplCommon(LevelDBTransaction* transaction, const Vector<char>&
lowKey, bool lowOpen, const Vector<char>& highKey, bool highOpen, bool forward,
bool unique)

The bools are out of hand. I don't think you should hold up this change, but a
future cleanup might be nice to use enums, an options struct or something else
to clean up these signatures.