[webkit-reviews] review requested: [Bug 55110] fast/forms/input-file-not-open-without-gesture.html passes when a file picker dialog is opened without a gesture. : [Attachment 94948] patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 02:23:14 PDT 2011


Johnny(Jianning) Ding <jnd at chromium.org> has asked  for review:
Bug 55110: fast/forms/input-file-not-open-without-gesture.html passes when a
file picker dialog is opened without a gesture.
https://bugs.webkit.org/show_bug.cgi?id=55110

Attachment 94948: patch v5
https://bugs.webkit.org/attachment.cgi?id=94948&action=review

------- Additional Comments from Johnny(Jianning) Ding <jnd at chromium.org>
(In reply to comment #35)
Thanks for comments, all done. 

Now I moved the startTest out of onload handler to make Event::fromUserGesture
grant that the mouseDown/up is a user gesture.

@Adam, would you like to review this patch?


More information about the webkit-reviews mailing list