[webkit-reviews] review canceled: [Bug 55110] fast/forms/input-file-not-open-without-gesture.html passes when a file picker dialog is opened without a gesture. : [Attachment 93429] patch v4 (fix style complain)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 02:23:14 PDT 2011


Johnny(Jianning) Ding <jnd at chromium.org> has canceled Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 55110: fast/forms/input-file-not-open-without-gesture.html passes when a
file picker dialog is opened without a gesture.
https://bugs.webkit.org/show_bug.cgi?id=55110

Attachment 93429: patch v4 (fix style complain)
https://bugs.webkit.org/attachment.cgi?id=93429&action=review

------- Additional Comments from Johnny(Jianning) Ding <jnd at chromium.org>
(In reply to comment #35)
Thanks for comments, all done. 

Now I moved the startTest out of onload handler to make Event::fromUserGesture
grant that the mouseDown/up is a user gesture.

@Adam, would you like to review this patch?


More information about the webkit-reviews mailing list