[webkit-reviews] review granted: [Bug 60917] [GTK][Cairo] Twitter rendering breaks : [Attachment 94891] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 60917: [GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

Attachment 94891: Patch
https://bugs.webkit.org/attachment.cgi?id=94891&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94891&action=review

LGTM. r=me

> Source/WebCore/ChangeLog:8
> +	   When instantiating a cairo_scaled_font_t font would pus the font in
an error state,

s/pus/push/ ?

> Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:98
> +    return adoptPtr(new
SimpleFontData(FontPlatformData(m_platformData.m_font.get(),
> +							   scaleFactor *
fontDescription.computedSize(),
> +							  
m_platformData.syntheticBold(),
> +							  
m_platformData.syntheticOblique()),
> +					  isCustomFont(), false));

ah ok, the alignment is correct.