[webkit-reviews] review denied: [Bug 19995] hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments. : [Attachment 94863] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 19995: hixie.ch : anchor Link fails with fragment identifiers inside SVG
fragments.
https://bugs.webkit.org/show_bug.cgi?id=19995

Attachment 94863: Patch
https://bugs.webkit.org/attachment.cgi?id=94863&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94863&action=review

r- because of a missing valid DRT test

> LayoutTests/svg/hixie/links/003.xml:24
> +  <svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
> +	  height="20000" width="200">
> +   <!-- Spec says that <a> can only link to animation elements,
> +	   otherwise it is invalid; that known attributes with
> +	   unsupported values are treated as if they hadn't been
> +	   specified when rendering; that if the attribute is not
> +	   specified, the effect is as if an empty value ("") was
> +	   specified; and that an empty attribute value (xlink:href="")
> +	   means that no link traversal occurs upon activation of the 'a'
> +	   element. So. Nothing should happen if you click it: -->
> +   <a xlink:href="#test">
> +    <circle cx="50" cy="50" r="50" fill="blue"/>
> +   </a>

Can't you write an automatic test with mousedown and check if "test" has the
focus() afterwards?