[webkit-reviews] review requested: [Bug 51586] CSSParser: m_implicitShorthand should probably be RAII : [Attachment 94635] [PATCH] darin@'s comments addressed (parameter retained for reuse by a subsequent patch)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 10:11:11 PDT 2011


Alexander Pavlov (apavlov) <apavlov at chromium.org> has asked  for review:
Bug 51586: CSSParser: m_implicitShorthand should probably be RAII
https://bugs.webkit.org/show_bug.cgi?id=51586

Attachment 94635: [PATCH] darin@'s comments addressed (parameter retained for
reuse by a subsequent patch)
https://bugs.webkit.org/attachment.cgi?id=94635&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
The class name "ImplicitScope" denotes the fact that it affects the state of
the "implicit" flag used by CSSParser when constructing property instances.
Once a property has been determined to be implicit or explicit, the
corresponding value can be passed into the ImplicitScope constructor (this is
handy for constructing the "font" property longhands).


More information about the webkit-reviews mailing list