[webkit-reviews] review granted: [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel : [Attachment 94610] Indent fix

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 59193: Web Inspector: Use different SourceFrame instances for
ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

Attachment 94610: Indent fix
https://bugs.webkit.org/attachment.cgi?id=94610&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94610&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:95
> +    _contentLoaded: function (callback, text)

Why not make it a local function in requestContent?

> Source/WebCore/inspector/front-end/ResourceView.js:-220
> -	   function contentLoaded(text)

What's the reason for moving this out of the requestContent?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:407
> +	   return treeElement.sourceView();

Can treeElement be undefined?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1189
> +    this._resource.addEventListener("errors-warnings-cleared",
this._errorsWarningsCleared, this);

You can listen for ConsoleCleared for consistency, otherwise some
console-related events come from Resources while others from the Console
directly.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:-1289
> -	   if (this._storagePanel.currentQuery)

Should this check be preserved?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1344
> +	   if (this._storagePanel.currentQuery)

Remove this.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1411
> +	   delete oldView;

This doesn't make sense, please remove.