[webkit-reviews] review denied: [Bug 61273] Wrap input color in feature flag : [Attachment 94562] fixed test & changelog

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 61273: Wrap input color in feature flag
https://bugs.webkit.org/show_bug.cgi?id=61273

Attachment 94562: fixed test & changelog
https://bugs.webkit.org/attachment.cgi?id=94562&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94562&action=review

r- because of a wrong test.

>
LayoutTests/fast/forms/script-tests/ValidityState-patternMismatch-unsupported.j
s:6
> -input.type = 'color';
> +input.type = 'range';
>  input.pattern = '#[0-9A-F]{6}';  // Restrict to capital letters
>  input.value = '#0099ff';

The intention of this test is to try to restrict valid values by pattern
attribute.
#0099ff is invalid for type=range, and pattern='#[0-9A-F]{6}' makes no sense
for type=range.

The 8th line still has 'type=color' in the comment.