[webkit-reviews] review denied: [Bug 61252] [Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long. : [Attachment 94563] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 61252: [Chromium]Add clipping for listBox in popup window to fix wrong
location display when the autofill item is really long.
https://bugs.webkit.org/show_bug.cgi?id=61252

Attachment 94563: Patch
https://bugs.webkit.org/attachment.cgi?id=94563&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94563&action=review

> Source/WebCore/manual-tests/autofill-popup-location.html:21
> +	 <li> Enter 'This is really long long long long long long long long
long long long long long long long long long long long long long long long long
long long long long long long long long long long long long long long long long
long long long long long long long long long long long long long long long long
long long long long long long long long long long long long long long long long
long long long long long long long long long long long long long long long long
long long long long long long long long text.' in the following text input
area.</li>

Does it mean type the text and then type ENTER to submit the form?

> Source/WebCore/manual-tests/autofill-popup-location.html:23
> +	 <li> Enter 'This is short text.' in the following text input
area.</li>

ditto.

> Source/WebCore/manual-tests/autofill-popup-location.html:29
> +    <form><input name=p autofocus></form>

This HTML already has an input with autofocus.	Multiple autofocus inputs are
confusing.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:170
> +	   , m_maxWindowWidth(INT_MAX)

Because this is a C++ code, we had better use numeric_limits<int>::max()
instead of INT_MAX.