[webkit-reviews] review denied: [Bug 56482] Make CSSMedia queries pass through Chrome and ChromeClient : [Attachment 86217] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 56482: Make CSSMedia queries pass through Chrome and ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=56482

Attachment 86217: Patch
https://bugs.webkit.org/attachment.cgi?id=86217&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86217&action=review

I disagree with this approach.	If we are doing this for fingerprinting
avoidance, we should write the anti-fingerprinting code in WebCore instead of
piping everything through WebKit.

>> Source/WebCore/css/MediaQueryEvaluator.cpp:222
>> +	int bitsPerComponent =
frame->page()->chrome()->screenDepthPerComponent();
> 
> What if page is null?

frame->page() can only be null during teardown, or?