[webkit-reviews] review granted: [Bug 58408] [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor : [Attachment 93982] more rebasing.

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 58408: [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl
portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Attachment 93982: more rebasing.
https://bugs.webkit.org/attachment.cgi?id=93982&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93982&action=review

You have some merge conflicts to ToT in WebViewImpl.cpp, but otherwise this
looks good.  Please ping darin on the WebWidget API change (although it seems
good to me).

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h:44
> +    explicit CCLayerTreeHostCommitter() { }

nit: the 'explicit' isn't needed for no-arg c'tor

> Source/WebKit/chromium/WebKit.gypi:59
> +	       'tests/DragImageTest.cpp',

hm? this change doesn't seem intentional

> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:156
> +void WebPopupMenuImpl::animate(double frameBeginTime)

nit: to avoid unused variable warnings, omit the parameter name here

> Source/WebKit/chromium/src/WebViewImpl.cpp:2521
> +	       context->reshape(std::max(1, m_size.width), std::max(1,
m_size.height));

nit: webkit style is to add a 'using namespace std' declaration for the file
and have the callsites just be max() (this is different from chromium style,
but them's the breaks)

> Source/WebKit/chromium/src/WebViewImpl.h:419
> +

nit: spurious newline here

> Source/WebKit/chromium/tests/CCThreadTest.cpp:54
> +

nit: spurious newline here