[webkit-reviews] review granted: [Bug 61131] [V8] Explicitly mark objects with complex GC rules. : [Attachment 94215] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 00:17:21 PDT 2011


Adam Barth <abarth at webkit.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 61131: [V8] Explicitly mark objects with complex GC rules.
https://bugs.webkit.org/show_bug.cgi?id=61131

Attachment 94215: patch
https://bugs.webkit.org/attachment.cgi?id=94215&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94215&action=review

That came out really nicely.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:235
> +    my $hasDependentLifetime =
$dataNode->extendedAttributes->{"V8DependentLifetime"} ||
IsActiveDomType($interfaceName) || $className =~ /SVG/;

$className =~ /SVG/;

sad face


More information about the webkit-reviews mailing list