[webkit-reviews] review granted: [Bug 61040] Web Inspector: initial showing of heap snapshot doesn't provide any feedback on waiting time : [Attachment 94258] comment addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 23 00:21:40 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 61040: Web Inspector: initial showing of heap snapshot doesn't provide any
feedback on waiting time
https://bugs.webkit.org/show_bug.cgi?id=61040
Attachment 94258: comment addressed
https://bugs.webkit.org/attachment.cgi?id=94258&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94258&action=review
> Source/WebCore/inspector/front-end/PleaseWaitMessage.js:90
> + listenObject.addEventListener(listenEvent,
WebInspector.PleaseWaitMessage.prototype.unlistenAndHide.bind(instance,
listenObject, listenEvent), instance);
Why no use a shorter notation: instance.unlistenAndHide.bind(instance,
listenObject, listenEvent)? Also, you don't need to pass instance as the third
parameter since you pass it in bind.
More information about the webkit-reviews
mailing list