[webkit-reviews] review granted: [Bug 61236] [chromium] Updating chromium DEPS : [Attachment 94318] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Greg Simon
<gregsimon at chromium.org>'s request for review:
Bug 61236: [chromium] Updating chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=61236

Attachment 94318: Patch
https://bugs.webkit.org/attachment.cgi?id=94318&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
r=me

but we probably dont want code in the webkit repository to depend on
ScopedTempDir.
it would make it very painful if someone ever changed that class in an
incompatible 
way.  how would the average chromium hacker know to fixup webkit?  and if they
did
know they would then have to deal with the circular dependency.  (hard to roll
webkit w/o things being temporarily broken .)

the contents of webkit_support.h mostly encapsulates the extent of the circular
deps 
which we have.	if you dont want to copy code into webkit, then consider
exposing 
the "algorithm" of interest as new functions in webkit_support.h.