[webkit-reviews] review granted: [Bug 61241] REGRESSION (r82144): Icon overlaps text in Twitter message dialog : [Attachment 94327] Add midpoints for positioned objects when adding a midpoint behind the current character

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 61241: REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241

Attachment 94327: Add midpoints for positioned objects when adding a midpoint
behind the current character
https://bugs.webkit.org/attachment.cgi?id=94327&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94327&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1777
> +void TrailingObjects::updateMidpointsForTrailingBoxes(LineMidpointState&
lineMidpointState, const InlineIterator& lBreak, bool mergeWithLineBreak)

Both call sites are passing constants, and the false and true at the call sites
are completely opaque, so this is one of those cases where an enum would make
things clearer than a bool.