[webkit-reviews] review granted: [Bug 55238] Web Inspector: Resizing columns in the network panel is weird : [Attachment 94071] Patch with style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 19 10:47:42 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted tonistiigi at gmail.com's
request for review:
Bug 55238: Web Inspector: Resizing columns in the network panel is weird
https://bugs.webkit.org/show_bug.cgi?id=55238

Attachment 94071: Patch with style fixes
https://bugs.webkit.org/attachment.cgi?id=94071&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94071&action=review

It looks good now, thanks. One nit you don't have to fix since it is minor +
would require re-review. I am marking this change as cq+ which means it'll land
automatically.

> Source/WebCore/inspector/front-end/DataGrid.js:965
> +	   if (this.resizeMethod == WebInspector.DataGrid.ResizeMethod.Last) {

Nit: single liners do not need {}


More information about the webkit-reviews mailing list