[webkit-reviews] review granted: [Bug 42079] SVG Large curve path segment OOM crash : [Attachment 94088] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 42079: SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079

Attachment 94088: Patch
https://bugs.webkit.org/attachment.cgi?id=94088&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94088&action=review

> Source/WebCore/platform/graphics/PathTraversalState.cpp:31
> +static const unsigned kCurveStackDepthLimit = 20;

This should just be local to the function, no need to have it global here.

> Source/WebCore/platform/graphics/PathTraversalState.cpp:128
> +	   if ((length - distanceLine(curve.start, curve.end)) >
kPathSegmentLengthTolerance && curveStack.size() < kCurveStackDepthLimit) {

If you wanted this to match your other results, I think you'll have to make
this <= instead of <.

> LayoutTests/svg/custom/path-getTotalLength-on-big-segment-crash.svg:15
> +<text x="10" y="30">Test passes if it does not crash.</text>

Lets make this dumpAsText then.