[webkit-reviews] review requested: [Bug 60875] [SOUP] Abnormal operation if server sends 5xx status code without HTTP body : [Attachment 94059] modify ChangeLog, add a new helper function, check handle->client() again

[bugzilla-daemon at webkit.org]

Keunsoon Lee <keunsoon.lee at samsung.com> has asked  for review:
Bug 60875: [SOUP] Abnormal operation if server sends 5xx status code without
HTTP body
https://bugs.webkit.org/show_bug.cgi?id=60875

Attachment 94059: modify ChangeLog, add a new helper function, check
handle->client() again
https://bugs.webkit.org/attachment.cgi?id=94059&action=review

------- Additional Comments from Keunsoon Lee <keunsoon.lee at samsung.com>
You can test the problematic situation on following test site.
    http://spe.mobilephone.net/wit/witguide.html
    WIT Root -> Common -> HTTP -> httperror.xhtml

If you are working with EFL port, you cannot find anything different between
attached patch and original code.
Because EFL port does not support download flow and does not have its own error
page.
But, you can see trying download on another port which is supporting download
or showing own error page.

I also found 4xx status code cause same problem, so add it on a new patch.

And check handle->client() again after calling didReceiveResponse() on
sendRequestCallback().
Because, WebCore makes handle->client() zero after didReceiveResponse() if
something wrong on received response.
(I guess it means cancel.)
For example, received response's Content-Type is "foo/foo", which you can test
on the test site.

Thank you.