[webkit-reviews] review denied: [Bug 55238] Web Inspector: Resizing columns in the network panel is weird : [Attachment 93976] Pathc

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied tonistiigi at gmail.com's request
for review:
Bug 55238: Web Inspector: Resizing columns in the network panel is weird
https://bugs.webkit.org/show_bug.cgi?id=55238

Attachment 93976: Pathc
https://bugs.webkit.org/attachment.cgi?id=93976&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93976&action=review

There is a series of style nits, but otherwise looks good. Thanks for fixing
this!

> Source/WebCore/inspector/front-end/DataGrid.js:927
> +	   if (typeof this._resizeMethod==="undefined")

Nit: this should be:

typeof this._resizeMethod === "undefined"

> Source/WebCore/inspector/front-end/DataGrid.js:965
> +	   if(this.resizeMethod==WebInspector.DataGrid.ResizeMethod.Last)

Spaces around == and before ( as well.

> Source/WebCore/inspector/front-end/DataGrid.js:966
> +	   {

Style for if is
if (foo === bar) {
...
}

> Source/WebCore/inspector/front-end/DataGrid.js:969
> +	   else if(this.resizeMethod==WebInspector.DataGrid.ResizeMethod.First)


ditto

> Source/WebCore/inspector/front-end/DataGrid.js:971
> +	      
leftEdgeOfPreviousColumn+=firstRowCells[leftCellIndex].offsetWidth -
firstRowCells[0].offsetWidth;

Spaces around += are missing.

> Source/WebCore/inspector/front-end/DataGrid.js:1011
> +    Nearest:    'nearest',

No need to align values into a column.
Please use " instead of '