[webkit-reviews] review denied: [Bug 60377] [WK2][Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux : [Attachment 93807] Removing the webgl enabler for wk2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 07:18:24 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Idrees
<sidreesshah at hotmail.com>'s request for review:
Bug 60377: [WK2][Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on
Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

Attachment 93807: Removing the webgl enabler for wk2
https://bugs.webkit.org/attachment.cgi?id=93807&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
You need to describe the change in the changelog, like why the assertion is not
needed.

Also, without changelog, it looks like you are fixing 2 unrelated things:
-The assert which is Qt specific
-The uniform name, which is common code.

I would prefer 2 patches with the test for each change.

Finally, how is this related to WebKit 2? Your changes only WebCore common
code?


More information about the webkit-reviews mailing list