[webkit-reviews] review granted: [Bug 45561] NULL deref when SVG elements have table styles : [Attachment 92582] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 45561: NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

Attachment 92582: Patch
https://bugs.webkit.org/attachment.cgi?id=92582&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92582&action=review

Looks good, r=me.

> Source/WebCore/css/CSSStyleSelector.cpp:3542
> +	   WTF_MAKE_NONCOPYABLE(SVGDisplayPropertyGuard);

Too much indented, 4 spaces are enough.

> Source/WebCore/css/CSSStyleSelector.cpp:3561
> +#if !ENABLE(SVG)
> +inline SVGDisplayPropertyGuard::SVGDisplayPropertyGuard(Element*,
RenderStyle*)
> +{
> +}
> +
> +inline SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard()
> +{
> +}
> +#else

I'd write it the other way round. #if ENABLE(SVG) ... #else .. #endif. Feel
free to leave it as-is though.

> Source/WebCore/css/CSSStyleSelector.cpp:3584
> +    if (!m_style)
> +	   return;
> +    if (isAcceptableForSVGElement(m_style->display()))
> +	   return;

You could turn this into one line.