[webkit-reviews] review granted: [Bug 60982] Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks. : [Attachment 93811] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 18:15:26 PDT 2011


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 60982: Exiting full screen will leave up invisible full-screen window,
blocking all mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=60982

Attachment 93811: Patch
https://bugs.webkit.org/attachment.cgi?id=93811&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93811&action=review

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:138
> +    if (m_rootLayer && m_rootLayer->children().contains(layer))
>	   return;

Seems a little silly to search the root layer for a layer of 0 when this is
called with 0. This check could go after the !layer check.


More information about the webkit-reviews mailing list