[webkit-reviews] review granted: [Bug 60943] Disable keyboard input (with exceptions) in full-screen mode. : [Attachment 93740] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 60943: Disable keyboard input (with exceptions) in full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60943

Attachment 93740: Patch
https://bugs.webkit.org/attachment.cgi?id=93740&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93740&action=review

> Source/WebCore/page/EventHandler.cpp:2442
> +    if ((keyCode >= VK_BACK && keyCode <= VK_CAPITAL)
> +	   || (keyCode >= VK_SPACE && keyCode <= VK_DELETE)
> +	   || (keyCode >= VK_OEM_1 && keyCode <= VK_OEM_PLUS)
> +	   || (keyCode >= VK_MULTIPLY && keyCode <= VK_OEM_8))
> +	   return true;
> +
> +    return false;

This seems quite unclear. Is this specific set of key code ranges straight out
of some specification? If not, what is the rationale for what keys are listed
here and what keys are not?

Also, if (x) return true; return false; is an anti-pattern. Just use a return.