[webkit-reviews] review granted: [Bug 60977] [chromium] Always set layerRenderer, even on non-drawn-layers : [Attachment 93805] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 60977: [chromium] Always set layerRenderer, even on non-drawn-layers
https://bugs.webkit.org/show_bug.cgi?id=60977

Attachment 93805: Patch
https://bugs.webkit.org/attachment.cgi?id=93805&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93805&action=review

Change looks good.  Is there any way to test this (even manually)?

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:353
> +	   renderSurfaceLayer->setLayerRenderer(this);

I think this is redundant - have you checked if this helps?  drawLayers() skips
render surfaces with an empty layer list (see
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/chromium/
LayerRendererChromium.cpp#L448).  I suppose it doesn't hurt to set it
regardless.