[webkit-reviews] review granted: [Bug 60942] Reduce code size for inline cache : [Attachment 93808] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 60942: Reduce code size for inline cache
https://bugs.webkit.org/show_bug.cgi?id=60942

Attachment 93808: Patch
https://bugs.webkit.org/attachment.cgi?id=93808&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93808&action=review

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:68
> +    static const int MaximumCompactPtrAlignedAddressOffset = 0x7FFFFFFF;

I think defining this here could be confusing, since you have have
implementations of load32WithAddressOffsetPatch in all macro assemblers.  To
avoid programmer errors I suggest moving this down into the architecture
specific MacroAssemblers.

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:44
> +    static const int MaximumCompactPtrAlignedAddressOffset = ((1 << 8) - 1)
/ 2;

I think just 127 would be clearer here.