[webkit-reviews] review denied: [Bug 42432] Enable Web Timing for GTK : [Attachment 93584] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 42432: Enable Web Timing for GTK
https://bugs.webkit.org/show_bug.cgi?id=42432

Attachment 93584: Patch
https://bugs.webkit.org/attachment.cgi?id=93584&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93584&action=review

Nice work. I think the new code in
Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp should only be
compiled in if web timing is enabled though.

> LayoutTests/platform/gtk/Skipped:-302
> +# Navigation Timing http tests that are still failing
>  http/tests/misc/webtiming-origins.html
> -http/tests/misc/webtiming-one-redirect.php
>  http/tests/misc/webtiming-slow-load.php
>  http/tests/misc/webtiming-ssl.php
> -http/tests/misc/webtiming-two-redirects.php

It'd be nice to have some understanding of why these are still failing.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:35
>  #include "ChromeClient.h"
>  #include "CookieJarSoup.h"
>  #include "CachedResourceLoader.h"
> +#include "CurrentTime.h"

Shouldn't all the new code in this file be guarded by #if ENABLE(WEB_TIMING)?