[webkit-reviews] review granted: [Bug 60682] Add DynamicsCompressorNode implementation : [Attachment 93528] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 16 12:32:02 PDT 2011
Stephen White <senorblanco at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 60682: Add DynamicsCompressorNode implementation
https://bugs.webkit.org/show_bug.cgi?id=60682
Attachment 93528: Patch
https://bugs.webkit.org/attachment.cgi?id=93528&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93528&action=review
Looks good. r=me
> Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp:298
> + double dbPerFrame = attenuationDb / satReleaseFrames;
Perf nit: This division could still be hoisted out of the loop (just a side
note, totally up to you if it's necessary).
More information about the webkit-reviews
mailing list