[webkit-reviews] review requested: [Bug 60818] Remove Node::deprecatedParserAddChild : [Attachment 93533] Updated patch with proper style.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 11:37:46 PDT 2011


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 60818: Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

Attachment 93533: Updated patch with proper style.
https://bugs.webkit.org/attachment.cgi?id=93533&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93533&action=review

> Source/WebCore/dom/XMLDocumentParser.h:193
> +	   RefPtr<Text> m_terminalTextNode;

I'm not sure I would call this "terminalTextNode".  Maybe m_currentTextNode? 
Or m_openTextNode?  Does "terminal text node" come from some spec somewhere?


More information about the webkit-reviews mailing list