[webkit-reviews] review denied: [Bug 60818] Remove Node::deprecatedParserAddChild : [Attachment 93533] Updated patch with proper style.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 60818: Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

Attachment 93533: Updated patch with proper style.
https://bugs.webkit.org/attachment.cgi?id=93533&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93533&action=review

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:81
>	   // FIXME: This code seems very wrong.  Why are we magically adding
|this| to the DOM here?
>	   //	     We shouldn't be calling parser API methods outside of the
parser!
> -	   parent->deprecatedParserAddChild(this);
> +	   toContainerNode(parent)->parserAddChild(this);

I don't think this part of the change is correct.  TextControlInnerElements is
not part of the parser and therefore should not be calling "parser" methods
like parserAddChild.

The rest looks pretty good though.