[webkit-reviews] review denied: [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector : [Attachment 93436] Minor fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 05:27:00 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Sergey Vorobyev
<sergeyvorobyev at google.com>'s request for review:
Bug 58652: Web Inspector: Background network events collection - add GUI to
Inspector
https://bugs.webkit.org/show_bug.cgi?id=58652

Attachment 93436: Minor fix
https://bugs.webkit.org/attachment.cgi?id=93436&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93436&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:352
> +	   if (!isBackgroundCollectionInit)

This may well be replaced with if (!m_eventsCollector), no need to introduce
additional field.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:397
> +void InspectorResourceAgent::backgroundCollectionInit()

initializeBackgroundCollection


More information about the webkit-reviews mailing list