[webkit-reviews] review granted: [Bug 60623] IndexedDB: Fix integer comparison bug in LevelDB coding routines : [Attachment 93114] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 60623: IndexedDB: Fix integer comparison bug in LevelDB coding routines
https://bugs.webkit.org/show_bug.cgi?id=60623

Attachment 93114: Patch
https://bugs.webkit.org/attachment.cgi?id=93114&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93114&action=review

> Source/WebCore/storage/IDBLevelDBCoding.cpp:202
> +static int compareInts(int64_t a, int64_t b)

Does this end up getting inlined still? How perf-sensitive are the callers?

> Source/WebCore/storage/IDBLevelDBCoding.cpp:-1049
> -    ret.append(encodeByte(kSchemaVersionTypeByte));

This looks like a stray diff. If it is intentional, please explain in the
ChangeLog.

> Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:38
> +// FIXME: We shouldn't need to rely on these macros.

This is also in IDBLevelDBCoding.cpp and IDBLevelDBBackingStore.cpp. Would be
nice to consolidate at some point.