[webkit-reviews] review granted: [Bug 59990] [GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480 : [Attachment 92019] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 12:34:05 PDT 2011


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 59990: [GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
https://bugs.webkit.org/show_bug.cgi?id=59990

Attachment 92019: Patch
https://bugs.webkit.org/attachment.cgi?id=92019&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92019&action=review

> Source/WebCore/platform/gtk/GtkVersioning.c:267
> +    g_assert(GDK_IS_PIXMAP(drawable) || GDK_IS_WINDOW(drawable));

This will crash in release builds, so better change it for g_return_if_fail.


More information about the webkit-reviews mailing list