[webkit-reviews] review granted: [Bug 60409] Convert x, y and width, height pairs to IntPoint and IntSize for RenderLayer : [Attachment 92827] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 12:35:38 PDT 2011


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 60409: Convert x,y and width,height pairs to IntPoint and IntSize for
RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=60409

Attachment 92827: Patch
https://bugs.webkit.org/attachment.cgi?id=92827&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92827&action=review

Fantastic!

> Source/WebCore/rendering/RenderLayer.cpp:1335
> +    IntSize newScrollOffset = IntSize(x - m_scrollOrigin.x(), y -
m_scrollOrigin.y());

I might have written this as IntPoint(x, y) - m_scrollOrigin, on the assumption
that eventually this function will take a point instead of an int pair.


More information about the webkit-reviews mailing list