[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 92708] Patch 2: TextureMapper API changes

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Attachment 92708: Patch 2: TextureMapper API changes
https://bugs.webkit.org/attachment.cgi?id=92708&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92708&action=review

> Source/WebCore/ChangeLog:11
> +	   1. an entry/exit point for painting (beginPaint/endPaint)

An*

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:97
> +    virtual void drawTexture(const BitmapTexture&, const FloatRect& target,
const TransformationMatrix& modelViewMatrix = TransformationMatrix(), float
opacity = 1.0f, const BitmapTexture* maskTexture = 0) = 0;

im not sure that the modelView adds value, it actually just make it more
confusing to me

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:108
> +    void setViewportSize(const IntSize& s) { m_viewportSize = s; }

I think writing size makes more sense