[webkit-reviews] review granted: [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch : [Attachment 92707] Patch 1: TextureMapperPlatformLayer API changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 8 04:33:04 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 60439: [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2
branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Attachment 92707: Patch 1: TextureMapperPlatformLayer API changes
https://bugs.webkit.org/attachment.cgi?id=92707&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92707&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:56
> -typedef TextureMapperPlatformLayer PlatformLayer;
> +typedef const TextureMapperPlatformLayer PlatformLayer;

So what is someone does "const PlatformLayer"? Wouldn't it be better to leave
out the const?


More information about the webkit-reviews mailing list