[webkit-reviews] review granted: [Bug 60240] CSP should block Function constructor : [Attachment 92368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 12:11:05 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 60240: CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

Attachment 92368: Patch
https://bugs.webkit.org/attachment.cgi?id=92368&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92368&action=review

OK.

> Source/JavaScriptCore/runtime/FunctionConstructor.cpp:75
>  JSObject* constructFunction(ExecState* exec, JSGlobalObject* globalObject,
const ArgList& args, const Identifier& functionName, const UString& sourceURL,
int lineNumber)

One could also just have added an enum argument to this call.


More information about the webkit-reviews mailing list