[webkit-reviews] review requested: [Bug 60174] Fix getUserMedia callback bindings for JSC : [Attachment 92619] Updated patch

[bugzilla-daemon at webkit.org]

Adam Bergkvist <adam.bergkvist at ericsson.com> has asked	for review:
Bug 60174: Fix getUserMedia callback bindings for JSC
https://bugs.webkit.org/show_bug.cgi?id=60174

Attachment 92619: Updated patch
https://bugs.webkit.org/attachment.cgi?id=92619&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
The problem can be solved while still using generated bindings. However, the
currently generated bindings fail due to a callback argument not being
translated correctly resulting in the handleEvent() function not being
overridden as it should (argument mismatch between int and int*). To avoid
updating the JSC bindings generator, the fix was to change the failing "dummy"
argument type to DOMString since primitive number types are not supported as
callback arguments. Also, in the webkitGetUserMedia() custom binding the
argument count is checked before trying to convert the first argument (fixes a
failure in the argument-types test).