[webkit-reviews] review granted: [Bug 60340] [chromium] Make IndexedDB code use WebPermissionClient API : [Attachment 92542] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 23:14:10 PDT 2011


James Robinson <jamesr at chromium.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 60340: [chromium] Make IndexedDB code use WebPermissionClient API
https://bugs.webkit.org/show_bug.cgi?id=60340

Attachment 92542: Patch
https://bugs.webkit.org/attachment.cgi?id=92542&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review

R= me. Do we have any way to test this stuff?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71
> +    if (webView->permissionClient()&&
!webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) {

Missing space before &&


More information about the webkit-reviews mailing list