[webkit-reviews] review granted: [Bug 57138] WebSocket urls should always be encoded as UTF-8 : [Attachment 92543] simplified fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Joe Mason <jmason at rim.com>'s request
for review:
Bug 57138: WebSocket urls should always be encoded as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=57138

Attachment 92543: simplified fix
https://bugs.webkit.org/attachment.cgi?id=92543&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92543&action=review

> Source/WebCore/websockets/WebSocket.h:66
> +	   // Use a String instead of a KURL for the url to ensure that
WebSocket
> +	   // parses the url itself using WebSocket rules (must be absolute and

> +	   // UTF-8 encoded).

Yeah, I agree.	Having a test for this behavior is more valuable than having a
comment.