[webkit-reviews] review denied: [Bug 47368] onclick on option elements doesn't work : [Attachment 80937] With changes from review comments

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dinu Jacob <dinu.jacob at Nokia.com>'s
request for review:
Bug 47368: onclick on option elements doesn't work
https://bugs.webkit.org/show_bug.cgi?id=47368

Attachment 80937: With changes from review comments
https://bugs.webkit.org/attachment.cgi?id=80937&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80937&action=review

> Source/WebCore/ChangeLog:12
> +	   * manual-tests/select-option-click.html: Added.

Why is this a manual test?  This seems like something we could test
automatically.

> Source/WebCore/html/HTMLSelectElement.cpp:102
> +    item(optionIndex)->dispatchSimulatedClick(0, false, false);

Will this fire if the user selects and option using the keyboard?  This seems
wrong.