[webkit-reviews] review denied: [Bug 53715] [chromium] Import PaintAggregator and introduce WebPaintSurface API : [Attachment 81117] v2 patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 53715: [chromium] Import PaintAggregator and introduce WebPaintSurface API
https://bugs.webkit.org/show_bug.cgi?id=53715

Attachment 81117: v2 patch
https://bugs.webkit.org/attachment.cgi?id=81117&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81117&action=review

I'm not sure whether you're still interested in this patch, but there are a
number of style nits reported by the bot.  I'm going to mark this R- for now
because we'll at least need to clean up the style problems.  If you're still
interested in the patch, please feel encouraged to upload a new version for
review.

> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:320
> +#if WEBKIT_USING_PAINTSURFACE

This doesn't seem like the right style of define.  Wouldn't USE(PAINTSURFACE)
or ENABLE(PAINTSURFACE) be more appropriate?